<html>
<head><meta charset="utf-8"><title>PR atomicity · t-cargo/PubGrub · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/index.html">t-cargo/PubGrub</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/PR.20atomicity.html">PR atomicity</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="214104597"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/PR%20atomicity/near/214104597" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Tokarev <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/PR.20atomicity.html#214104597">(Oct 21 2020 at 19:45)</a>:</h4>
<p>Recently I've submitted <a href="https://github.com/pubgrub-rs/pubgrub/pull/48">a refactoring PR</a> that did 10 separate things. There wasn't one self contained logical feature I was working on, so I got just small changes that piled on.<br>
I'm afraid that doing so made it too cumbersome for review.<br>
On the other hand, it made those squashable if we would like to do so. (Does it make sense there?)</p>
<p>Another strategy would be to flood PR sections with 1 commit each, doing 10 (hopefully) independent PRs.<br>
Easy to review, impossible to squash without force pushing <code>dev</code>.<br>
Would this be better or would it create an unnecessary noise?</p>
<p>I would like to hear what kind of PRs you prefer to adjust my strategy for the future.</p>



<a name="214105871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/260232-t-cargo/PubGrub/topic/PR%20atomicity/near/214105871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Eh2406 <a href="https://rust-lang.github.io/zulip_archive/stream/260232-t-cargo/PubGrub/topic/PR.20atomicity.html#214105871">(Oct 21 2020 at 19:54)</a>:</h4>
<p>It worked out well. Reviewing by commit made it clear what you were doing.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>